Bug 87741 - Don't build readline/libreadline.a in GDB, when --with-system-readline is supplied
Summary: Don't build readline/libreadline.a in GDB, when --with-system-readline is sup...
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: other (show other bugs)
Version: 7.3.1
: P3 normal
Target Milestone: 13.0
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-24 19:42 UTC by Дилян Палаузов
Modified: 2022-10-21 06:57 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2021-08-26 00:00:00


Attachments
Why don’t the GCC mailservers accept my email to gcc-pathces? (2.15 KB, application/mbox)
2018-10-26 07:20 UTC, Дилян Палаузов
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Дилян Палаузов 2018-10-24 19:42:32 UTC
Please integrate this snippet, so that gdb can skip building the shipped libreadline, when the system-libreadline is used, see https://sourceware.org/bugzilla/show_bug.cgi?id=18632 for details


diff --git a/configure.ac b/configure.ac
--- a/configure.ac
+++ b/configure.ac
@@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi
 
+# Don't compile the bundled readline/libreadline.a in gdb-binutils if
+#  --with-system-readline is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 # some tools are so dependent upon X11 that if we're not building with X, 
 # it's not even worth trying to configure, much less build, that tool.
Comment 1 Andrew Pinski 2018-10-24 20:07:57 UTC
Patches should be sent to gcc-patches@ after reading https://gcc.gnu.org/contribute.html .
Comment 2 Дилян Палаузов 2018-10-26 07:20:04 UTC
Created attachment 44905 [details]
Why don’t the GCC mailservers accept my email to gcc-pathces?
Comment 3 Jonathan Wakely 2018-10-26 09:37:26 UTC
https://gcc.gnu.org/lists.html#policies

The mailing lists reject emails with MIME types like text/html or mixed/multipart, they only accept plain text.
Comment 4 Дилян Палаузов 2018-10-26 10:00:48 UTC
The mail I send has only text/plain MIME part.  Moreover, the mail was not permanently rejected.

I want to know why the mail server says "Retry sending later".
Comment 5 jsm-csl@polyomino.org.uk 2018-10-26 15:47:01 UTC
Send email issues to postmaster@sourceware.org (not overseers, that's 
another mailing list on the same server).
Comment 6 Дилян Палаузов 2018-10-27 19:55:38 UTC
I have misspelled the domain — gnu.gcc.org
Comment 7 Andrew Pinski 2021-08-26 05:58:58 UTC
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;f=configure.ac;h=69961a84c9b3744a10248fb6cbccc3c688a1e0a5

It would be useful if both configures were synced up again ....
Comment 8 Tom de Vries 2022-10-21 06:57:46 UTC
(In reply to Andrew Pinski from comment #7)
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;f=configure.ac;
> h=69961a84c9b3744a10248fb6cbccc3c688a1e0a5
> 
> It would be useful if both configures were synced up again ....

https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=36ba985145ffa8e2078033fc1f1cf22851707a8e