Bug 79453 - Translator unfriendly string in avr_pgm_check_var_decl
Summary: Translator unfriendly string in avr_pgm_check_var_decl
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: target (show other bugs)
Version: 7.0
: P5 minor
Target Milestone: 6.4
Assignee: Not yet assigned to anyone
URL:
Keywords: diagnostic
Depends on:
Blocks:
 
Reported: 2017-02-10 13:58 UTC by Frederic Marchal
Modified: 2017-04-18 13:33 UTC (History)
1 user (show)

See Also:
Host:
Target: avr
Build:
Known to work:
Known to fail:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Marchal 2017-02-10 13:58:20 UTC 
In gcc/config/avr/avr.c, at line, 9831 (inside avr_pgm_check_var_decl()), one can find this error message:

    error ("pointer targeting address space %qs must be const"
           " in %s %q+D",
             avr_addrspace[as].name, reason, node);

The "reason" variable contains an untranslated text such as "variable", "function parameter", "return type of function", and so on. Building a string out of fragments doesn't play well at all with translations.

I'm afraid every reason should have its own error message.
Comment 1 Georg-Johann Lay 2017-04-18 13:33:33 UTC 
Fixed in r246966 and r246967