Bug 67787 - [6 Regression] wrong code at -O3 on x86_64-linux-gnu
Summary: [6 Regression] wrong code at -O3 on x86_64-linux-gnu
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: rtl-optimization (show other bugs)
Version: 6.0
: P3 normal
Target Milestone: 6.0
Assignee: ktkachov
URL:
Keywords: wrong-code
Depends on:
Blocks:
 
Reported: 2015-09-30 16:21 UTC by Zhendong Su
Modified: 2023-06-02 01:10 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail: 6.0
Last reconfirmed: 2015-09-30 00:00:00


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zhendong Su 2015-09-30 16:21:18 UTC
The current gcc trunk miscompiles the following code on x86_64-linux-gnu at -O3 in both 32-bit and 64-bit modes. 

This is a regression from 5.2.x.

I wasn't able to get rid of the call to printf. 


$ gcc-trunk -v
Using built-in specs.
COLLECT_GCC=gcc-trunk
COLLECT_LTO_WRAPPER=/usr/local/gcc-trunk/libexec/gcc/x86_64-pc-linux-gnu/6.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: ../gcc-trunk/configure --prefix=/usr/local/gcc-trunk --enable-languages=c,c++ --disable-werror --enable-multilib
Thread model: posix
gcc version 6.0.0 20150930 (experimental) [trunk revision 228291] (GCC) 
$ 
$ gcc-trunk -O2 small.c; ./a.out
 $ 
$ gcc-5.2 -O3 small.c; ./a.out
 $ 
$ 
$ gcc-trunk -O3 small.c
$ ./a.out
 Aborted
$ 


----------------------------------------------------


int printf (const char *, ...);

int a, c, f, g;
char b;

static int
fn1 ()
{
  char h;
  int k = -1, i, j;
  for (; b < 16; b++)
    ;
  printf (" ");
  if (b < 5)
    k++;
  if (k)
    {
      int l = 2;
      a = h = b < 0 || b > (127 >> l) ? b : b << 1;
      return 0;
    }
  for (i = 0; i < 1; i++)
    for (j = 0; j < 7; j++)
      f = 0;
  for (c = 0; c; c++)
    ;
  if (g)
    for (;;)
      ;
  return 0;
}

int
main ()
{
  fn1 ();
  
  if (a != 32) 
    __builtin_abort (); 

  return 0;
}
Comment 1 Marek Polacek 2015-09-30 17:11:59 UTC
Started with r228194.
Comment 2 ktkachov 2015-09-30 17:20:00 UTC
Confirmed. I have a patch in testing.
Comment 3 ktkachov 2015-10-02 08:37:17 UTC
Author: ktkachov
Date: Fri Oct  2 08:36:45 2015
New Revision: 228375

URL: https://gcc.gnu.org/viewcvs?rev=228375&root=gcc&view=rev
Log:
[RTL ifcvt] PR 67786, 67787: Check that intermediate instructions in the basic block don't clobber a reg used in condition

        PR rtl-optimization/67786
        PR rtl-optimization/67787
        * ifcvt.c (bb_valid_for_noce_process_p): Reject basic block if
        it modifies a reg used in the condition calculation.

        * gcc.dg/pr67786.c: New test.
        * gcc.dg/pr67787.c: Likewise.


Added:
    trunk/gcc/testsuite/gcc.dg/pr67786.c
    trunk/gcc/testsuite/gcc.dg/pr67787.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ifcvt.c
    trunk/gcc/testsuite/ChangeLog
Comment 4 ktkachov 2015-10-02 08:39:00 UTC
Fixed on trunk.