Bug 67432 - Improve error message on empty enum
Summary: Improve error message on empty enum
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: c (show other bugs)
Version: 6.0
: P3 normal
Target Milestone: 6.0
Assignee: Marek Polacek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-02 07:19 UTC by Chengnian Sun
Modified: 2015-09-02 21:25 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2015-09-02 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chengnian Sun 2015-09-02 07:19:33 UTC 
IMHO, it would be better to improve the error message on empty enumeration.  

$: cat t.c
enum E {};
$: gcc-trunk -c t.c
t.c:1:9: error: expected identifier before ‘}’ token
 enum E {};
         ^
$: clang-trunk -c t.c
t.c:1:9: error: use of empty enum
enum E {};
        ^
1 error generated.
$
Comment 1 Marek Polacek 2015-09-02 14:39:34 UTC 
Confirmed.
Comment 2 Marek Polacek 2015-09-02 21:01:10 UTC 
Author: mpolacek
Date: Wed Sep  2 21:00:38 2015
New Revision: 227421

URL: https://gcc.gnu.org/viewcvs?rev=227421&root=gcc&view=rev
Log:
	PR c/67432
	* c-parser.c (c_parser_enum_specifier): Give a better error for
	an empty enum.

	* gcc.dg/pr67432.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr67432.c
Modified:
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-parser.c
    trunk/gcc/testsuite/ChangeLog
Comment 3 Marek Polacek 2015-09-02 21:01:36 UTC 
Done.
Comment 4 Chengnian Sun 2015-09-02 21:25:03 UTC 
(In reply to Marek Polacek from comment #3)
> Done.

This is very fast. Thanks, Marek.