Bug 65460 - parloops transforms offloaded functions
Summary: parloops transforms offloaded functions
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: tree-optimization (show other bugs)
Version: 5.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords: openacc, openmp, patch
Depends on:
Blocks:
 
Reported: 2015-03-18 08:55 UTC by Tom de Vries
Modified: 2015-06-09 21:17 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2015-03-18 00:00:00


Attachments
tentative patch (319 bytes, patch)
2015-03-18 08:56 UTC, Tom de Vries
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom de Vries 2015-03-18 08:55:00 UTC
The offload variant of PR65458 - parloops transforms omp-thread functions.

AFAIU, running the parloops pass on the host version of offloaded functions, may as well speed up as degrade performance. 

It's probably best to disable parloops for offloaded functions, at least until we do a targeted exercise to speed up host execution of offloaded functions.
Comment 1 Tom de Vries 2015-03-18 08:56:04 UTC
Created attachment 35052 [details]
tentative patch
Comment 2 Richard Biener 2015-03-18 11:27:39 UTC
Confirmed.
Comment 3 Tom de Vries 2015-03-21 22:23:24 UTC
Author: vries
Date: Sat Mar 21 22:22:52 2015
New Revision: 221562

URL: https://gcc.gnu.org/viewcvs?rev=221562&root=gcc&view=rev
Log:
Mark offloaded functions as parallelized

2015-03-21  Tom de Vries  <tom@codesourcery.com>

	PR tree-optimization/65460
	* omp-low.c (expand_omp_target): Set parallelized_function on
	cgraph_node for child_fn.

Modified:
    branches/gomp-4_0-branch/gcc/ChangeLog
    branches/gomp-4_0-branch/gcc/omp-low.c
Comment 4 Tom de Vries 2015-04-17 10:15:39 UTC
stage1 ping: https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00861.html
Comment 5 Tom de Vries 2015-06-08 12:27:37 UTC
patch: https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01063.html
Comment 6 Tom de Vries 2015-06-08 12:34:05 UTC
stage1 ping^2: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00557.html
Comment 7 Tom de Vries 2015-06-09 21:15:18 UTC
Author: vries
Date: Tue Jun  9 21:14:46 2015
New Revision: 224303

URL: https://gcc.gnu.org/viewcvs?rev=224303&root=gcc&view=rev
Log:
Mark offloaded functions as parallelized

2015-06-09  Tom de Vries  <tom@codesourcery.com>

	PR tree-optimization/65460
	* omp-low.c (expand_omp_target): Set parallelized_function on
	cgraph_node for child_fn.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/omp-low.c
Comment 8 Tom de Vries 2015-06-09 21:17:23 UTC
patch committed to trunk, marking resolved fixed.