62275 – ARM should use vcvta instructions when possible for float -> int rounding

Bug 62275 - ARM should use vcvta instructions when possible for float -> int rounding

Summary: ARM should use vcvta instructions when possible for float -> int rounding

Status:	RESOLVED FIXED

Alias:	None

Product:	gcc
Classification:	Unclassified
Component:	target (show other bugs)
Version:	5.0

Importance:	P3 enhancement
Target Milestone:	5.0
Assignee:	ktkachov

URL:
Keywords:

Depends on:
Blocks:

Reported:	2014-08-26 23:11 UTC by Joshua Conner
Modified:	2014-10-08 15:38 UTC (History)
CC List:	0 users

See Also:
Host:
Target:	arm
Build:
Known to work:	5.0
Known to fail:
Last reconfirmed:	2014-09-01 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joshua Conner 2014-08-26 23:11:42 UTC

Instead of generating a library call for lround/lroundf, the ARM backend should use vcvta.s32.f64 and vcvta.s32.f32 instructions instead (as long as -fno-math-errno has been given, since this obviously won't set errno).

Comment 1 ktkachov 2014-09-01 16:13:46 UTC

Confirmed, and mine.

Comment 2 ktkachov 2014-09-02 15:58:28 UTC

Author: ktkachov
Date: Tue Sep  2 15:57:56 2014
New Revision: 214825

URL: https://gcc.gnu.org/viewcvs?rev=214825&root=gcc&view=rev
Log:
[ARM][1/2] Implement lceil, lfloor, lround optabs with new ARMv8-A instructions.
                                                                                                                                                                             
      PR target/62275
      * config/arm/iterators.md (FIXUORS): New code iterator.
      (VCVT): New int iterator.
      (su_optab): New code attribute.
      (su): Likewise.
      * config/arm/vfp.md (l<vrint_pattern><su_optab><mode>si2): New pattern.

      PR target/62275
      * gcc.target/arm/lceil-vcvt_1.c: New test.
      * gcc.target/arm/lfloor-vcvt_1.c: Likewise.
      * gcc.target/arm/lround-vcvt_1.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.target/arm/lceil-vcvt_1.c
    trunk/gcc/testsuite/gcc.target/arm/lfloor-vcvt_1.c
    trunk/gcc/testsuite/gcc.target/arm/lround-vcvt_1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/iterators.md
    trunk/gcc/config/arm/vfp.md
    trunk/gcc/testsuite/ChangeLog

Comment 3 ktkachov 2014-09-02 16:00:33 UTC

Author: ktkachov
Date: Tue Sep  2 16:00:01 2014
New Revision: 214826

URL: https://gcc.gnu.org/viewcvs?rev=214826&root=gcc&view=rev
Log:
[2/2] Vectorise lroundf, lfloorf, lceilf using the new ARMv8-A vcvt* instructions.

	PR target/62275
	* config/arm/neon.md
	(neon_vcvt<NEON_VCVT:nvrint_variant><su_optab><VCVTF:mode>
	<v_cmp_result>): New pattern.
	* config/arm/iterators.md (NEON_VCVT): New int iterator.
	* config/arm/arm_neon_builtins.def (vcvtav2sf, vcvtav4sf, vcvtauv2sf,
	vcvtauv4sf, vcvtpv2sf, vcvtpv4sf, vcvtpuv2sf, vcvtpuv4sf, vcvtmv2sf,
	vcvtmv4sf, vcvtmuv2sf, vcvtmuv4sf): New builtin definitions.
	* config/arm/arm.c (arm_builtin_vectorized_function): Handle
	BUILT_IN_LROUNDF, BUILT_IN_LFLOORF, BUILT_IN_LCEILF.

	PR target/62275
	* gcc.target/arm/vect-lceilf_1.c: New test.
	* gcc.target/arm/vect-lfloorf_1.c: Likewise.
	* gcc.target/arm/vect-lroundf_1.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.target/arm/vect-lceilf_1.c
    trunk/gcc/testsuite/gcc.target/arm/vect-lfloorf_1.c
    trunk/gcc/testsuite/gcc.target/arm/vect-lroundf_1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c
    trunk/gcc/config/arm/arm_neon_builtins.def
    trunk/gcc/config/arm/iterators.md
    trunk/gcc/config/arm/neon.md
    trunk/gcc/testsuite/ChangeLog

Comment 4 ktkachov 2014-09-02 16:01:28 UTC

Fixed on trunk

Comment 5 Joshua Conner 2014-09-02 17:23:27 UTC

Thanks!

Comment 6 Yvan Roux 2014-10-08 15:38:15 UTC

Author: yroux
Date: Wed Oct  8 15:37:43 2014
New Revision: 216007

URL: https://gcc.gnu.org/viewcvs?rev=216007&root=gcc&view=rev
Log:
gcc/
2014-10-08  Yvan Roux  <yvan.roux@linaro.org>

	Backport from trunk r214825, r214826.
	2014-09-02  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	PR target/62275
	* config/arm/neon.md
	(neon_vcvt<NEON_VCVT:nvrint_variant><su_optab><VCVTF:mode>
	<v_cmp_result>): New pattern.
	* config/arm/iterators.md (NEON_VCVT): New int iterator.
	* config/arm/arm_neon_builtins.def (vcvtav2sf, vcvtav4sf, vcvtauv2sf,
	vcvtauv4sf, vcvtpv2sf, vcvtpv4sf, vcvtpuv2sf, vcvtpuv4sf, vcvtmv2sf,
	vcvtmv4sf, vcvtmuv2sf, vcvtmuv4sf): New builtin definitions.
	* config/arm/arm.c (arm_builtin_vectorized_function): Handle
	BUILT_IN_LROUNDF, BUILT_IN_LFLOORF, BUILT_IN_LCEILF.

	2014-09-02  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	PR target/62275
	* config/arm/iterators.md (FIXUORS): New code iterator.
	(VCVT): New int iterator.
	(su_optab): New code attribute.
	(su): Likewise.
	* config/arm/vfp.md (l<vrint_pattern><su_optab><mode>si2): New pattern.

gcc/testsuite/
2014-10-08  Yvan Roux  <yvan.roux@linaro.org>

	Backport from trunk r214825, r214826, r215085.
	2014-09-09  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	* gcc.target/arm/vect-lceilf_1.c: Make input and output arrays global
	and 16-byte aligned.
	* gcc.target/arm/vect-lfloorf_1.c: Likewise.
	* gcc.target/arm/vect-lroundf_1.c: Likewise.
	* gcc.target/arm/vect-rounding-btruncf.c: Likewise.
	* gcc.target/arm/vect-rounding-ceilf.c: Likewise.
	* gcc.target/arm/vect-rounding-floorf.c: Likewise.
	* gcc.target/arm/vect-rounding-roundf.c: Likewise.

	2014-09-02  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	PR target/62275
	* gcc.target/arm/vect-lceilf_1.c: New test.
	* gcc.target/arm/vect-lfloorf_1.c: Likewise.
	* gcc.target/arm/vect-lroundf_1.c: Likewise.

	2014-09-02  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	PR target/62275
	* gcc.target/arm/lceil-vcvt_1.c: New test.
	* gcc.target/arm/lfloor-vcvt_1.c: Likewise.
	* gcc.target/arm/lround-vcvt_1.c: Likewise.


Added:
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/lceil-vcvt_1.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/lfloor-vcvt_1.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/lround-vcvt_1.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/vect-lceilf_1.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/vect-lfloorf_1.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/vect-lroundf_1.c
Modified:
    branches/linaro/gcc-4_9-branch/gcc/ChangeLog.linaro
    branches/linaro/gcc-4_9-branch/gcc/config/arm/arm.c
    branches/linaro/gcc-4_9-branch/gcc/config/arm/arm_neon_builtins.def
    branches/linaro/gcc-4_9-branch/gcc/config/arm/iterators.md
    branches/linaro/gcc-4_9-branch/gcc/config/arm/neon.md
    branches/linaro/gcc-4_9-branch/gcc/config/arm/vfp.md
    branches/linaro/gcc-4_9-branch/gcc/testsuite/ChangeLog.linaro
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/vect-rounding-btruncf.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/vect-rounding-ceilf.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/vect-rounding-floorf.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/vect-rounding-roundf.c