Bug 58867 - asan and ubsan tests not run for installed testing
Summary: asan and ubsan tests not run for installed testing
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 4.9.0
: P3 normal
Target Milestone: 5.0
Assignee: Andrew Pinski
URL: http://gcc.gnu.org/ml/gcc-patches/201...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-10-25 00:55 UTC by Joseph S. Myers
Modified: 2015-06-26 20:40 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2013-10-25 00:00:00


Attachments
Patch which I am testing (1.25 KB, patch)
2013-10-28 22:33 UTC, Andrew Pinski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph S. Myers 2013-10-25 00:55:39 UTC
gcc.dg/asan/asan.exp checks if asan_init succeeds before running anything, and likewise for gcc.dg/ubsan/ubsan.exp.  Success is determined in asan_init as meaning that a nonempty set of link flags was produced.  But for installed toolchain testing, the logic for finding like flags won't find any, and this doesn't matter - the library will already be installed where the installed compiler can find it, and LD_LIBRARY_PATH is the board file's responsibility.  Thus, the right way to test for success is whether a test file can be successfully linked with the determined options, not whether the determined options are nonempty.
Comment 1 Andrew Pinski 2013-10-25 01:20:17 UTC
I ran into this also.  I have a fix for both.
Comment 2 Andrew Pinski 2013-10-28 22:33:44 UTC
Created attachment 31101 [details]
Patch which I am testing

This is the patch which I am testing right now.
Comment 3 Jakub Jelinek 2014-04-22 11:35:51 UTC
GCC 4.9.0 has been released
Comment 4 Jakub Jelinek 2014-07-16 13:27:50 UTC
GCC 4.9.1 has been released.
Comment 5 Maxim Ostapenko 2014-10-03 14:23:05 UTC
This is fixed by r215793, but I forgot to mention it in commit message. So, ok to resolve as fixed?
Comment 6 Jakub Jelinek 2014-10-30 10:37:52 UTC
GCC 4.9.2 has been released.
Comment 7 Jakub Jelinek 2015-06-26 19:59:00 UTC
GCC 4.9.3 has been released.
Comment 8 Andrew Pinski 2015-06-26 20:40:54 UTC
Fixed so closing.