Bug 112751 - [14 regression] gcc.target/powerpc/pcrel-sibcall-1.c fails after r14-5628-g53ba8d669550d3
Summary: [14 regression] gcc.target/powerpc/pcrel-sibcall-1.c fails after r14-5628-g53...
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 14.0
: P3 normal
Target Milestone: 14.0
Assignee: Kewen Lin
URL: https://gcc.gnu.org/pipermail/gcc-pat...
Keywords: testsuite-fail
Depends on:
Blocks:
 
Reported: 2023-11-28 20:47 UTC by seurer
Modified: 2024-01-10 05:21 UTC (History)
3 users (show)

See Also:
Host: powerpc64le-linux-gnu
Target: powerpc64le-linux-gnu
Build: powerpc64le-linux-gnu
Known to work:
Known to fail:
Last reconfirmed: 2023-11-29 00:00:00


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description seurer 2023-11-28 20:47:58 UTC
g:53ba8d669550d3a1f809048428b97ca607f95cf5, r14-5628-g53ba8d669550d3
make  -k check-gcc RUNTESTFLAGS="powerpc.exp=gcc.target/powerpc/pcrel-sibcall-1.c"
FAIL: gcc.target/powerpc/pcrel-sibcall-1.c scan-assembler \\mb x@notoc\\M
FAIL: gcc.target/powerpc/pcrel-sibcall-1.c scan-assembler \\mbl y\\M
FAIL: gcc.target/powerpc/pcrel-sibcall-1.c scan-assembler \\mb xx@notoc\\M
# of expected passes		2
# of unexpected failures	3


commit 53ba8d669550d3a1f809048428b97ca607f95cf5 (HEAD)
Author: Jan Hubicka <jh@suse.cz>
Date:   Mon Nov 20 19:35:53 2023 +0100

    inter-procedural value range propagation
Comment 1 Andrew Pinski 2023-11-28 20:55:44 UTC
This is just a testsuite issue. The functions are currently marked as noinline.  You can either add -fno-ipa-vrp or mark them with noipa instead. I am not sure if noipa here is right due to having some ipa happening due to localization.
Comment 2 Kewen Lin 2023-11-29 06:36:42 UTC
(In reply to Andrew Pinski from comment #1)
> This is just a testsuite issue. The functions are currently marked as
> noinline.  You can either add -fno-ipa-vrp or mark them with noipa instead.
> I am not sure if noipa here is right due to having some ipa happening due to
> localization.

Thanks for looking into this, I just tested with noipa and confirmed it worked well.
Comment 3 GCC Commits 2024-01-10 05:09:48 UTC
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:57792c33042d17605a6b6ad9027f5e6d5199eb26

commit r14-7092-g57792c33042d17605a6b6ad9027f5e6d5199eb26
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Tue Jan 9 23:06:13 2024 -0600

    testsuite, rs6000: Adjust pcrel-sibcall-1.c with noipa [PR112751]
    
    As PR112751 shows, commit r14-5628 caused pcrel-sibcall-1.c
    to fail as it enables ipa-vrp which makes return values of
    functions {x,y,xx} as known and propagated.  This patch is
    to adjust it with noipa to make it not fragile.
    
            PR testsuite/112751
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/powerpc/pcrel-sibcall-1.c: Replace noinline as noipa.
Comment 4 Kewen Lin 2024-01-10 05:21:12 UTC
Should be fixed.