Bug 109388 - clang warnings related to Modula-2
Summary: clang warnings related to Modula-2
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: modula2 (show other bugs)
Version: 13.0
: P3 normal
Target Milestone: ---
Assignee: Gaius Mulley
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-03 08:38 UTC by Martin Liška
Modified: 2023-04-03 14:06 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2023-04-03 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Liška 2023-04-03 08:38:37 UTC 
I see some clang warnings related to M2:

m2/gm2-compiler-boot/M2GCCDeclare.c:8085:67: warning: unused parameter 'module' [-Wunused-parameter]
m2/gm2-compiler-boot/PHBuild.c:3384:13: warning: unused function 'PeepToken' [-Wunused-function]
m2/gm2-compiler-boot/PHBuild.c:3880:13: warning: unused function 'PushQualident' [-Wunused-function]
m2/gm2-compiler-boot/PHBuild.c:6735:13: warning: unused function 'SimpleDes' [-Wunused-function]
m2/gm2-compiler-boot/PHBuild.c:6755:13: warning: unused function 'ActualParameters' [-Wunused-function]
Comment 1 Gaius Mulley 2023-04-03 09:14:52 UTC 
Indeed thanks for reporting this - will fix.
Comment 2 GCC Commits 2023-04-03 14:05:16 UTC 
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:9a75f0a02e5006e081b335acd36300a85bef8eb8

commit r13-6987-g9a75f0a02e5006e081b335acd36300a85bef8eb8
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Apr 3 15:04:06 2023 +0100

    PR modula2/109388 clang warnings related to Modula-2
    
    This patch removes an unused parameter 'module' from
    DoVariableDeclaration in M2GCCDeclare.mod.  It also removes unused
    procedures from PHBuild.bnf.
    
    gcc/m2/ChangeLog:
    
            PR modula2/109388
            * gm2-compiler/M2GCCDeclare.mod (DoVariableDeclaration):
            Remove second parameter module.  Adjust all callers to
            remove the second parameter.
            * gm2-compiler/PHBuild.bnf (CheckAndInsert): Remove.
            (InStopSet): Remove.
            (PeepToken): Remove.
            (PushQualident): Remove.
            (SimpleDes): Remove.
            (ActualParameters): Remove.
    
    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>
Comment 3 Gaius Mulley 2023-04-03 14:06:06 UTC 
Closing as the patch has been applied - thanks for reporting the bug.