Bug 108890 - Translation mistakes 2023
Summary: Translation mistakes 2023
Status: UNCONFIRMED
Alias: None
Product: gcc
Classification: Unclassified
Component: translation (show other bugs)
Version: 13.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords: diagnostic
Depends on:
Blocks:
 
Reported: 2023-02-22 18:12 UTC by Roland Illig
Modified: 2024-01-16 17:39 UTC (History)
5 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Illig 2023-02-22 18:12:18 UTC
> %qs is loaded but symbol %qs is not found: %s

That string is marked as 'format-c' but should be 'format-gcc-internal'.

> to generate dependencies you must specify '-fcpp'

Trailing whitespace, wrong quotes.

> -frust-crate=<name>             Set the crate name for the compilation
> -frust-dump-<type>\tDump Rust frontend internal information.

The upper is indented using spaces, the lower using a single tab.
That's inconsistent.

> -frust-max-recursion-depth=integer

Placeholders should be enclosed in <>.

> -frust-mangling=[legacy|v0]     Choose which version to use for name mangling

The word 'Choose' is redundant and should be removed.
This word occurs in other messages as well.

> Flag to enable embeding metadata directly into object files

The word 'Flag' is redundant.
Typo in 'embeding'.

> -frust-compile-until=[ast|attributecheck|expansion|nameresolution|lowering|typecheck|privacy|unsafety|const|copimlation|end]             When to stop in the pipeline when compiling Rust code

The word 'until' sounds inclusive, the phrase 'When to stop' sounds exclusive.
Typo in 'copimlation'.

> inproper usages

Typo in 'inproper'.

> Enable certain features present drafts of C++ Contracts.

Grammar?
Comment 1 Richard Biener 2023-02-23 08:38:28 UTC
most are rust specific, CCing maintainer
Comment 2 Thomas Schwinge 2023-02-23 09:05:16 UTC
I've filed as *good-first-pr* <https://github.com/Rust-GCC/gccrs/issues/1916> 'Diagnostics and option help texts: GCC PR108890 "Translation mistakes 2023"'.
Comment 3 Jakub Jelinek 2023-02-23 09:24:19 UTC
(In reply to Roland Illig from comment #0)
> > %qs is loaded but symbol %qs is not found: %s
> 
> That string is marked as 'format-c' but should be 'format-gcc-internal'.

This is xtensa-dynconfig.c (and there are other strings from it too).
I wonder if this isn't because the file is still named *.c rather than *.cc, otherwise
no ideas.  Because the messages are in fatal_error...

> > to generate dependencies you must specify '-fcpp'
> 
> Trailing whitespace, wrong quotes.

This is in m2 FE.

> > Enable certain features present drafts of C++ Contracts.
> 
> Grammar?

This one is C++, rest is Rust.
Comment 5 GCC Commits 2023-02-23 14:28:06 UTC
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:9f9a7095d910379cd86ac45f81c79b363f859996

commit r13-6304-g9f9a7095d910379cd86ac45f81c79b363f859996
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Feb 23 15:27:31 2023 +0100

    c++: Fix up -fcontracts option description [PR108890]
    
    This translation PR mentioned the description is a little bit weird.
    
    2023-02-23  Jakub Jelinek  <jakub@redhat.com>
    
            PR translation/108890
            * c.opt (fcontracts): Fix description.
Comment 6 GCC Commits 2023-02-23 22:27:21 UTC
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:7423f5b56ad436f51ac1b9defb954e2bdc5b06ab

commit r13-6307-g7423f5b56ad436f51ac1b9defb954e2bdc5b06ab
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Feb 23 23:26:43 2023 +0100

    xtensa: Fix up fatal_error message strings in xtensa-dynconfig.c [PR108890]
    
    The translation PR complains that these 4 messages from xtensa-dynconfig.c
    are marked in po/gcc.pot as c-format (which doesn't allow %qs) while they
    should be gcc-internal-format.
    
    The problem is in the manual translation of the strings with _(),
    that should be both unnecessary because fatal_error invokes _() on its
    argument already, but also incorrect for the above reason, for
    gcc-internal-format strings one should use G_("...") instead if really
    needed.
    
    The following patch drops those _("..."), tested by regenerating po/gcc.pot
    to see they are now gcc-internal-format, but not really tested on xtensa
    target.
    
    2023-02-23  Jakub Jelinek  <jakub@redhat.com>
    
            PR translation/108890
            * config/xtensa/xtensa-dynconfig.c (xtensa_load_config): Drop _()s
            around fatal_error format strings.
Comment 7 GCC Commits 2024-01-16 17:39:40 UTC
The trunk branch has been updated by Arthur Cohen <cohenarthur@gcc.gnu.org>:

https://gcc.gnu.org/g:747d9a92ddb74fa7ba1bb6ca0079abd5eaa38791

commit r14-7504-g747d9a92ddb74fa7ba1bb6ca0079abd5eaa38791
Author: TieWay59 <tieway59@foxmail.com>
Date:   Wed Apr 19 14:07:34 2023 +0800

    gccrs: Fix translation mistakes 2023 in GCC/Rust [PR108890]
    
    In https://gcc.gnu.org/PR108890 "Translation mistakes 2023"
    @rillig lists several issues with GCC/Rust diagnostics and
    option help texts (but also a few non-GCC/Rust).
    
    This commit fix mistakes only related to GCC/Rust,
    specifically to the file `gcc/rust/lang.opt`.
    
    closes https://github.com/Rust-GCC/gccrs/issues/1916
    
            PR translation/108890
            gcc/rust/
            * lang.opt: Fix translation mistakes 2023 in
            GCC/Rust [PR108890]
            (line 67): change the inconsistent tab to spaces
            (line 75): wrap bare placeholder `integer`
            (line 79): remove redundant text of `Choose which`
            (line 96): remove redundant text of `Choose which`
            (line 112): remove redundant `Flag to`
            (line 124): correct the exclusive term `When to stop`
            (line 124): correct typo of `copimlation`
    
    Signed-off-by: Tieway59 <tieway59@foxmail.com>