Bug 104818 - Duplicate word "version" in option -mptx description
Summary: Duplicate word "version" in option -mptx description
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: target (show other bugs)
Version: 12.0
: P3 normal
Target Milestone: 12.0
Assignee: Not yet assigned to anyone
URL:
Keywords: documentation
Depends on:
Blocks:
 
Reported: 2022-03-07 13:20 UTC by Göran Uddeborg
Modified: 2022-03-28 16:41 UTC (History)
2 users (show)

See Also:
Host:
Target: nvptx
Build:
Known to work:
Known to fail:
Last reconfirmed: 2022-03-07 00:00:00


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Göran Uddeborg 2022-03-07 13:20:42 UTC
In `config/nvptx/nvptx.opt` there is an error message

    Specify the version of the ptx version to use.

https://github.com/gcc-mirror/gcc/blob/2472dcaa8cb9e02e902f83d419c3ee7e0f3d9041/gcc/config/nvptx/nvptx.opt#L80

I guess "version of version" is not what was intended.
Comment 1 GCC Commits 2022-03-28 16:39:25 UTC
The master branch has been updated by Tom de Vries <vries@gcc.gnu.org>:

https://gcc.gnu.org/g:0127fb1b78a36a7b228d4b3fe32eedfc8d273363

commit r12-7858-g0127fb1b78a36a7b228d4b3fe32eedfc8d273363
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Mar 28 17:55:49 2022 +0200

    [nvptx] Improve help description of misa and mptx
    
    Currently we have:
    ...
    $ gcc --target-help 2>&1 | egrep "misa|mptx"
      -misa=                      Specify the version of the ptx ISA to use.
      -mptx=                      Specify the version of the ptx version to use.
      Known PTX ISA versions (for use with the -misa= option):
      Known PTX versions (for use with the -mptx= option):
    ...
    
    As reported in PR104818, the "version of the ptx version" doesn't make much
    sense.
    
    Furthermore, the description of misa (and 'Known ISA versions') is misleading
    because it does not specify the version of the PTX ISA, but rather the PTX ISA
    target architecture.
    
    Fix this by printing instead:
    ...
    $ gcc --target-help 2>&1 | egrep "misa|mptx"
      -misa=                      Specify the PTX ISA target architecture to use.
      -mptx=                      Specify the PTX ISA version to use.
      Known PTX ISA target architectures (for use with the -misa= option):
      Known PTX ISA versions (for use with the -mptx= option):
    ...
    
    Tested on nvptx.
    
    gcc/ChangeLog:
    
    2022-03-28  Tom de Vries  <tdevries@suse.de>
    
            PR target/104818
            * config/nvptx/gen-opt.sh (ptx_isa): Improve help text.
            * config/nvptx/nvptx-gen.opt: Regenerate.
            * config/nvptx/nvptx.opt (misa, mptx, ptx_version): Improve help text.
            * config/nvptx/t-nvptx (s-nvptx-gen-opt): Add missing dependency on
            gen-opt.sh.
Comment 2 Tom de Vries 2022-03-28 16:40:52 UTC
Fixed in aforementioned commit.