[libstdc++-v3] PR 59529, 59530, 59531 Was(Re: Implement N3762 string_view: a non-owning reference to a string.)

[Paolo Carlini]

Hi,

On 12/22/2013 02:56 AM, Ed Smith-Rowland wrote:
> I've looked over these patches (thanks Peter!) and tweaked up a couple 
> patches (no need to leave commented out tests, and copy can start from 
> pos=length()).
> I'm finishing testing on x86_64-linux.
>
> Paolo, are there any Copyright issues we need to be aware of? Does 
> Peter need a Copyright form?  These are fairly obvious one-liners I 
> think.  There are no real alternatives to these patches.  What 
> ChangeLog attribution is appropriate?
If Peter means to contribute more, he definitely needs a Copyright 
assignment, and, as we all know, had better starting the process as soon 
as possible, it may take time.

For this specific issue, if the actual fixes are very small, and 
straightforward, I think can be committed just now, with both his name 
and yours name in the ChangeLog (since you spent time investigating, 
integrating and testing the whole thing). You may also want to split out 
to a separate ChangeLog the testcases, under your name only, since that 
would make the "potentially problematic" commit much smaller. I did that 
myself quite a few times in the past.

Many thanks to both of view, anyway, please make sure to carefully 
commit everything before committing!

Thanks,
Paolo.