Fix PR 17741

Paolo Carlini pcarlini@suse.de
Thu Oct 28 15:52:00 GMT 2004


Chris Jefferson wrote:

> PR 17741 is a simple problem, where the specialisations of find and 
> find_if have not been uglified. This simple patch fixes it.
>
> Tested on x86/linux.

Hi Chris.

I have two comments of the type once-and-for-all ;) ...

    1- Please follow our conventions for the ChangeLog entry (just have 
a look to the file)
    2- Please use diff -u (-p unfortunately is not very useful for C++) 
and typically -R (again, just have a look to the past postings for the 
details)

... and two more, specific to this patch:
    3- Do you actually have a testcase or not? ;)
    4- In my opinion, this kind of change is more suited for v7-branch.

Paolo.



More information about the Libstdc++ mailing list