Fix PR 17741

Chris Jefferson caj@cs.york.ac.uk
Thu Oct 28 16:44:00 GMT 2004


Paolo Carlini wrote:

> Chris Jefferson wrote:
>
>> PR 17741 is a simple problem, where the specialisations of find and 
>> find_if have not been uglified. This simple patch fixes it.
>>
>> Tested on x86/linux.
>
>
> Hi Chris.
>
> I have two comments of the type once-and-for-all ;) ...
>
>    1- Please follow our conventions for the ChangeLog entry (just have 
> a look to the file)
>    2- Please use diff -u (-p unfortunately is not very useful for C++) 
> and typically -R (again, just have a look to the past postings for the 
> details)
>
Sorry sorry! I've tried again. Hopefully this patch is correct in all 
ways (famous last words...)

> ... and two more, specific to this patch:
>    3- Do you actually have a testcase or not? ;)

Yep, now attached

>    4- In my opinion, this kind of change is more suited for v7-branch.
>
I agree. In fact I was torn about if I should bother submitting this, as 
I can't see anyone ever actually coming across this bug...

Chris
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: CL_find_findif
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20041028/8196bfb4/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_find_findif
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20041028/8196bfb4/attachment-0001.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: find.cc
Type: text/x-c++src
Size: 1147 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20041028/8196bfb4/attachment.bin>


More information about the Libstdc++ mailing list