[PATCH] testsuite: Make stdio-common/tst-printf-format-*-mem UNSUPPORTED if the mtrace output does not exist

Andreas K. Huettel dilfridge@gentoo.org
Sun Jan 26 19:23:39 GMT 2025


Am Sonntag, 26. Januar 2025, 14:51:34 Mitteleuropäische Normalzeit schrieb Sam James:
> Xi Ruoyao <xry111@xry111.site> writes:
> 
> > When gawk was not built with MPFR, there's no mtrace output and those
> > tests FAIL.  But we should make them UNSUPPORTED like other
> > tst-printf-format-* tests in the case.
> >
> > Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> 
> Reviewed-by: Sam James <sam@gentoo.org>

Thank you both and pushed.

> 
> > ---
> >  stdio-common/Makefile | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/stdio-common/Makefile b/stdio-common/Makefile
> > index bbdc1ff709..840289afd9 100644
> > --- a/stdio-common/Makefile
> > +++ b/stdio-common/Makefile
> > @@ -599,8 +599,11 @@ $(objpfx)tst-%-mem.out: $(objpfx)tst-%.out
> >  	$(common-objpfx)malloc/mtrace $(objpfx)tst-$*.mtrace > $@; \
> >  	$(evaluate-test)
> >  $(objpfx)tst-printf-format-%-mem.out: $(objpfx)tst-printf-format-%.out
> > -	$(common-objpfx)malloc/mtrace \
> > -	  $(objpfx)tst-printf-format-$*.mtrace > $@; \
> > +	{ test -r $(objpfx)tst-printf-format-$*.mtrace \
> > +	|| ( echo "$(objpfx)tst-printf-format-$*.mtrace does not exist"; \
> > +	     exit 77; ) \
> > +	&& $(common-objpfx)malloc/mtrace \
> > +	  $(objpfx)tst-printf-format-$*.mtrace; } > $@; \
> >  	$(evaluate-test)
> >  
> >  errlist-h = $(firstword $(wildcard $(addsuffix /errlist.h,$(sysdirs) .)))
> 


-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 981 bytes
Desc: This is a digitally signed message part.
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20250126/12dba645/attachment.sig>


More information about the Libc-alpha mailing list