[PATCH] testsuite: Make stdio-common/tst-printf-format-*-mem UNSUPPORTED if the mtrace output does not exist

Sam James sam@gentoo.org
Sun Jan 26 13:51:34 GMT 2025


Xi Ruoyao <xry111@xry111.site> writes:

> When gawk was not built with MPFR, there's no mtrace output and those
> tests FAIL.  But we should make them UNSUPPORTED like other
> tst-printf-format-* tests in the case.
>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>

Reviewed-by: Sam James <sam@gentoo.org>

> ---
>  stdio-common/Makefile | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/stdio-common/Makefile b/stdio-common/Makefile
> index bbdc1ff709..840289afd9 100644
> --- a/stdio-common/Makefile
> +++ b/stdio-common/Makefile
> @@ -599,8 +599,11 @@ $(objpfx)tst-%-mem.out: $(objpfx)tst-%.out
>  	$(common-objpfx)malloc/mtrace $(objpfx)tst-$*.mtrace > $@; \
>  	$(evaluate-test)
>  $(objpfx)tst-printf-format-%-mem.out: $(objpfx)tst-printf-format-%.out
> -	$(common-objpfx)malloc/mtrace \
> -	  $(objpfx)tst-printf-format-$*.mtrace > $@; \
> +	{ test -r $(objpfx)tst-printf-format-$*.mtrace \
> +	|| ( echo "$(objpfx)tst-printf-format-$*.mtrace does not exist"; \
> +	     exit 77; ) \
> +	&& $(common-objpfx)malloc/mtrace \
> +	  $(objpfx)tst-printf-format-$*.mtrace; } > $@; \
>  	$(evaluate-test)
>  
>  errlist-h = $(firstword $(wildcard $(addsuffix /errlist.h,$(sysdirs) .)))


More information about the Libc-alpha mailing list