[PATCH v15 4/8] nptl: add rtld_hidden_proto to __rseq_size and __rseq_offset

[Michael Jeanson]

On 2025-01-08 03:49, Florian Weimer wrote:
> * Michael Jeanson:
> 
>> This allows accessing the internal aliases of __rseq_size and
>> __rseq_offset from ld.so without ifdefs and avoids a PLT entry in ld.so
>> for both variables.
> 
>> +/* We want to use rtld_hidden_proto in order to call the internal aliases
>> +   of __rseq_size and __rseq_offset from ld.so.  This avoids a PLT entry in
>> +   ld.so for both variables.   */
>> +rtld_hidden_proto (__rseq_size)
>> +rtld_hidden_proto (__rseq_offset)
> 
> I think PLT isn't technically correct because these aren't procedures.
> GOT entry isn't correct, either, because there are architectures that
> access hidden variables through GOT entries.  Maybe “avoids dynamic
> symbol binding at run time” describes it best?

Ack, I'll update the commit message and comment.

> 
> The change itself looks okay.
> 
> Thanks,
> Florian
>