[PATCH v15 4/8] nptl: add rtld_hidden_proto to __rseq_size and __rseq_offset

Florian Weimer fweimer@redhat.com
Wed Jan 8 08:49:08 GMT 2025


* Michael Jeanson:

> This allows accessing the internal aliases of __rseq_size and
> __rseq_offset from ld.so without ifdefs and avoids a PLT entry in ld.so
> for both variables.

> +/* We want to use rtld_hidden_proto in order to call the internal aliases
> +   of __rseq_size and __rseq_offset from ld.so.  This avoids a PLT entry in
> +   ld.so for both variables.   */
> +rtld_hidden_proto (__rseq_size)
> +rtld_hidden_proto (__rseq_offset)

I think PLT isn't technically correct because these aren't procedures.
GOT entry isn't correct, either, because there are architectures that
access hidden variables through GOT entries.  Maybe “avoids dynamic
symbol binding at run time” describes it best?

The change itself looks okay.

Thanks,
Florian



More information about the Libc-alpha mailing list