PATCH, libjava: silence more warnings
Tue Dec 1 20:15:00 GMT 2009
Tom Tromey wrote:
>>>>>> "Dave" == Dave Korn <email@example.com> writes:
> Dave> Ben Elliston wrote:
>>> ::java::lang::String *
>>> -java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes,
>>> - jint valid)
>>> +java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes __attribute__ ((unused)),
>>> + jint valid __attribute__ ((unused)))
> Dave> There's a #define MAYBE_UNUSED in include/jvm.h, as used in
> Dave> java/lang/natClass.cc. But maybe jvm.h isn't available here?
> It is ok to include jvm.h from any of the CNI code.
> But, it is also ok to just use an unadorned __attribute__. We know this
> code can only be compiled by g++.
... given which, it's hardly worth adding a new header dependency just to
get the macro. Right, thanks for clarifying that.
More information about the Java