PATCH, libjava: silence more warnings

Tom Tromey tromey@redhat.com
Tue Dec 1 19:44:00 GMT 2009


>>>>> "Dave" == Dave Korn <dave.korn.cygwin@googlemail.com> writes:

Dave> Ben Elliston wrote:
>> ::java::lang::String *
>> -java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes,
>> -                                                       jint valid)
>> +java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes __attribute__ ((unused)),
>> +                                                       jint valid __attribute__ ((unused)))

Dave>   There's a #define MAYBE_UNUSED in include/jvm.h, as used in
Dave> java/lang/natClass.cc.  But maybe jvm.h isn't available here?

It is ok to include jvm.h from any of the CNI code.

But, it is also ok to just use an unadorned __attribute__.  We know this
code can only be compiled by g++.

Tom



More information about the Java mailing list