comparision of classpath and gcj java.io.StreamTokenizer

Anthony Green green@cygnus.com
Sun Jul 23 10:30:00 GMT 2000


On Saturday, July 22, 2000 4:59 PM, Tom Tromey [SMTP:tromey@cygnus.com] 
wrote:
> But, is paperwork even required for a change which is a merger of GPL
> code like this?  Does anyone know the answer to that?

My guess is that it's ok.  Most of the patch is documentation directly from 
Classpath.  There are a couple of trivial patches we would probably accept 
without assignment, and then there are a number of methods that changed like 
this:

   private boolean isWhitespace(int ch)
   {
-    if (ch >= 0 && ch <= 255)
-      return whitespace[ch];
-
-    return false;
+    return (ch >= 0 && ch <= 255 && whitespace[ch]);
   }

FWIW - the compiler output should be identical.  I actually prefer the 
original code.

(btw - thanks Oskar!)

AG



More information about the Java mailing list