[Patch] Silence some compiler warnings.

David Daney ddaney@avtrex.com
Thu May 17 03:56:00 GMT 2007


Tom Tromey wrote:
>>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
>>>>>>             
>
> David> Some of the C++ files that make up libgcj are generating compiler
> David> warnings.  This patch silences them, and also removes a dead union
> David> definition that I encountered along the way.
> David> Tested on x86_64-pc-linux-gnu with no regressions.
>
> David> OK to commit?
>
> Yes, thanks.  One little note...
>
> David> -    while (! compare_and_swap (&lock, 0, 1));
> David> +    while (! compare_and_swap (&lock, 0, 1)) ;
>
> In cases like this I prefer the ';' on its own line, to emphasize the
> loop's emptiness.  Call it "Sartre style".
>
>   
Committed thusly:
2007-05-16  David Daney  <ddaney@avtrex.com>

    * include/java-stack.h (_Jv_FrameInfo): Remove union definition.
    (_Jv_StackFrame): Remove commented out code.
    (_Jv_UnwindState): Remove superfluous 'typedef'.
    * sun/misc/natUnsafe.cc (spinlock): Add white space to quiet
    compiler warnings.
    * gnu/java/lang/management/natVMMemoryPoolMXBeanImpl.cc
    (getCollectionUsage): Don't declare unused parameter n.
    (getMemoryManagerNames): Same.
    * gnu/gcj/util/natGCInfo.cc (gc_debug_info): Remove superfluous
    'typedef'.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup.diff
Type: text/x-patch
Size: 2533 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20070517/3498c20d/attachment.bin>


More information about the Java-patches mailing list