[Patch] Silence some compiler warnings.
Tom Tromey
tromey@redhat.com
Thu May 17 02:14:00 GMT 2007
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> Some of the C++ files that make up libgcj are generating compiler
David> warnings. This patch silences them, and also removes a dead union
David> definition that I encountered along the way.
David> Tested on x86_64-pc-linux-gnu with no regressions.
David> OK to commit?
Yes, thanks. One little note...
David> - while (! compare_and_swap (&lock, 0, 1));
David> + while (! compare_and_swap (&lock, 0, 1)) ;
In cases like this I prefer the ';' on its own line, to emphasize the
loop's emptiness. Call it "Sartre style".
If you are in a warning-killing mood, Ian pointed out that we have
some overflow warnings to fix. These have the added bonus that they
probably reflect real bugs :-)
Tom
More information about the Java-patches
mailing list