BasicMenUI calls protected JMenu methods

Olga Rodimina rodimina@redhat.com
Mon Jun 28 14:10:00 GMT 2004


On Sat, 2004-06-26 at 09:28, Mark Wielaard wrote:
> Hi,
> 
> While integrating the latest gui-branch drop into GNU Classpath and
> testing with the jikes 2.21 compiler I noticed that BasicMenUI calls two
> protected JMenu methods. I fixed those by just removing them:
> 
> 2004-06-26  Mark Wielaard  <mark@klomp.org>
> 
>         * javax/swing/plaf/basic/BasicMenuUI.java (mousePressed): Don't call
>         protected JMenu methods fireMenuCanceled() and fireMenuSelected().
> 
> It looks like the MenuSelectionManager should take care of this when
> clearSelectedPath() or setSelectedPath() is called.
> 

Yes, these methods should be called by JMenu's menuSelectiongChanged()
which is invoked by MenuSelectionManager. I already committed a patch to
fix this on Jun 22 to java-gui-branch, but this fix is not in mainline
yet.

-- 
Olga Rodimina <rodimina@redhat.com>



More information about the Java-patches mailing list