BasicMenUI calls protected JMenu methods

Mark Wielaard mark@klomp.org
Sat Jun 26 15:14:00 GMT 2004


Hi,

While integrating the latest gui-branch drop into GNU Classpath and
testing with the jikes 2.21 compiler I noticed that BasicMenUI calls two
protected JMenu methods. I fixed those by just removing them:

2004-06-26  Mark Wielaard  <mark@klomp.org>

        * javax/swing/plaf/basic/BasicMenuUI.java (mousePressed): Don't call
        protected JMenu methods fireMenuCanceled() and fireMenuSelected().

It looks like the MenuSelectionManager should take care of this when
clearSelectedPath() or setSelectedPath() is called.

Unfortunately I don't have any test program to check this patch.
I have checked it into GNU Classpath for the moment.
Could one of the Swing gui wizards take a look at this?

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: BasicMenuUI.patch
Type: text/x-patch
Size: 833 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040626/0ef6ac54/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040626/0ef6ac54/attachment.sig>


More information about the Java-patches mailing list