AC_COMPILE_CHECK_SIZEOF

[Jones Desougi]

> Yes, well, mainline is the place for not-simple-one-line-fixes.
> Although, we are on the threshold of stage 3 of development, so this
> might be better held for 3.6.

Right, the place but not always.

> Does this bug cause any problems in mainline?

It's a latent bug. Perhaps you do not consider such worth fixing.
In that case we disagree.

In retrospect I would make a minor change to how the original patch resolves
the issue, but that's academic if another way altogether is prefered.

The obvious difference between AC_CHECK_SIZEOF and AC_COMPILE_CHECK_SIZEOF
is that if type is unknown the former sets the size to zero while the latter
issues an error. AC_CHECK_SIZEOF also has a simple sanity check on its first
argument, demanding a literal.
Would you approve a patch that cuts over to AC_CHECK_SIZEOF?

    /Jones