AC_COMPILE_CHECK_SIZEOF

[Zack Weinberg]

"Giovanni Bajo" <rasky@develer.com> writes:

> Zack Weinberg wrote:
>
>>>> For mainline, I think it would be better if you cut us over to
>>>> plain AC_CHECK_SIZEOF, which works correctly when cross-compiling in
>>>> autoconf 2.5x.
>>>
>>> That isn't a simple one line fix though. :-)
>>
>> Yes, well, mainline is the place for not-simple-one-line-fixes.
>> Although, we are on the threshold of stage 3 of development, so this
>> might be better held for 3.6.
>
> Why? I thought that Stage 3 was for fixing bugs, even if you need to
> rearrange the code or do non trivial changes. It is the release
> branch where we fix only regressions, and possibly with one liners.
> Am I wrong?

No, you're not wrong.  But keep in mind that my impression here is
that there is no actual bug, although I'm not sure why the original
poster wants to change the macro in that case.  As such, I'm being
rather more conservative about what's an okay change than I might.

If the 2.5x AC_CHECK_SIZEOF were a drop-in replacement for our
AC_COMPILE_CHECK_SIZEOF - and it certainly ought to be - then I'd be
fine with that change during stage 3 even if it fixed no user-visible
bugs (since the archaic kludges in the configure script are themselves
bugs).  And if there are semantic differences, I still might be fine
with changing it and fixing up whatever fallout results, but we have
to proceed with somewhat more caution.

zw