[gcc r16-6970] unswitch: Fix up one unguarded fprintf (dump_file, ...) [PR123736]
Jakub Jelinek
jakub@gcc.gnu.org
Thu Jan 22 09:12:18 GMT 2026
https://gcc.gnu.org/g:613fef9239aa723ea65b1118262bb63d023169c4
commit r16-6970-g613fef9239aa723ea65b1118262bb63d023169c4
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Jan 22 10:11:34 2026 +0100
unswitch: Fix up one unguarded fprintf (dump_file, ...) [PR123736]
This dump message is not guarded on dump_file being non-NULL, so crashes
inside of libc if dump_file is NULL.
I think a message like that is usually guarded not just on dump_file
being non-NULL, but also on TDF_DETAILS set in dump_flags.
2026-01-22 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/123736
* tree-ssa-loop-unswitch.cc (hoist_guard): Guard dump message
on dump_file && (dump_flags & TDF_DETAILS) condition.
Diff:
---
gcc/tree-ssa-loop-unswitch.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/tree-ssa-loop-unswitch.cc b/gcc/tree-ssa-loop-unswitch.cc
index 7831a442851d..96680bc64ea3 100644
--- a/gcc/tree-ssa-loop-unswitch.cc
+++ b/gcc/tree-ssa-loop-unswitch.cc
@@ -1459,7 +1459,8 @@ hoist_guard (class loop *loop, edge guard)
if (skip_count > e->count ())
{
- fprintf (dump_file, " Capping count; expect profile inconsistency\n");
+ if (dump_file && (dump_flags & TDF_DETAILS))
+ fprintf (dump_file, " Capping count; expect profile inconsistency\n");
skip_count = e->count ();
}
if (dump_enabled_p ())
More information about the Gcc-cvs
mailing list