[Bug c/53131] -Wlogical-op: ready for prime time in -Wall ?

[marc.glisse at normalesup dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53131

Marc Glisse <marc.glisse at normalesup dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marc.glisse at normalesup
                   |                            |dot org

--- Comment #4 from Marc Glisse <marc.glisse at normalesup dot org> 2012-04-28 12:05:20 UTC ---
(In reply to comment #2)
> > Do the warnings indicate bugs or not?
> Yes. I checked the first ten.

Could you give a sample? -Wlogical-op merges 2 unrelated warnings:
*) x && 2 (you would expect a boolean, not 2, so maybe x&2 was meant)
*) x<0 && x>0 (not so likely to happen) or x>=-5 || x<2 (always true)

and it is not clear which one you are most interested in.