[Bug c/53131] -Wlogical-op: ready for prime time in -Wall ?

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53131

--- Comment #3 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2012-04-28 10:37:04 UTC ---
(In reply to comment #2)
> > 
> > Do the warnings indicate bugs or not?
> 
> Yes. I checked the first ten.

And what do the kernel people say? Do they want Wlogical-op enabled?

> > There is also PR43772, which would be nice to fix before enabling this in -Wall
> > or -Wextra. However, I don't even have any idea why we are warning there.
> 
> Agreed, although I wouldn't regard one broken corner case as a show stopper.
> 

Unfortunately, this corner case triggers in Emacs, so I guess it is not that
uncommon. My intention is to try to fix it before touching the status of
-Wlogical-op. This will make easier to convince GCC maintainers. However, I
have a long list of other things I would like to fix firstm and very little
free time, so if you (or anyone else) managed to find out why that bug
triggers, it would help already a lot.