[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[dog at bluezoo dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From dog at bluezoo dot org  2003-08-22 17:36 -------
Subject: Re:  fastjar error: "Error in JAR file format. zip-style comment?"

pinskia at gcc dot gnu dot org wrote:
> These all work for me on the mainline on powerpc-apple-darwin6.6 so I still cannot reproduce it.

the code where it fails (fastjar/jartool.c:1587-1594) goes:

  #ifdef WORDS_BIGENDIAN
    tmp = L2BI(tmp);
  #endif

  if(tmp != 0x06054b50){
    fprintf(stderr, "Error in JAR file format. zip-style comment?\n");
    exit(1);
  }

i have tested the value of tmp. it is 0x504b0506. WORDS_BIGENDIAN has
not been defined, and therefore L2BI is never called (it is never
even declared). however it seems relatively clear to me that it /should/
have been called, as powerpc is a bigendian architecture.

surely the Makefile for fastjar needs to define (or not)
WORDS_BIGENDIAN, as appropriate?

> I also cannot reproduce it on 3.3.1 (20030707) on i686-pc-linux-gnu.  

as far as i know it has always worked on i386, which is a little-endian
architecture in any case.