Missing spaces in dg directives.

Mikael Morin mikael.morin@tele2.fr
Tue Jan 6 14:25:00 GMT 2009


Dominique Dhumieres wrote:
> It has been a long time I have not palyed to find missing spaces
> in dg directives. Here is the catch of today:
> 
(...)
Is it unrecognized by deja-gnu or is it just a cosmetic change?
In any case, I think it can go to trunk.

> 
> While I am at it, could the following patch applied too:
> 
> --- ../_gcc_clean/gcc/testsuite/gfortran.dg/pr37243.f	2008-12-10 09:08:04.000000000 +0100
> +++ gcc/testsuite/gfortran.dg/pr37243.f	2008-12-10 09:10:17.000000000 +0100
> @@ -35,7 +35,7 @@
>        IF (J .GT. N) GO TO 320
>        DO 240 K = 1,N
>    240 V(K,I) = ZERO
> -      CALL DAXPY(N,DUM,V(1,II),1,V(1,I),1)
> +      CALL DAXPY(N,DUM,V(1,I),1,V(1,I),1)
>    260 CONTINUE
>        DUMI = ZERO
>        DO 280 K = 1,N
> 
> The variable II is a typo that trigger a false positive with -fbounds-check
> (II is not initialized).
Yes, PR 38235.
While I haven't understood what the testcase does, your change looks good.
I think it can go in too.

You don't have commit access, do you?
I can commit for you if you want.

Thanks
Mikael



More information about the Fortran mailing list