Committed: [patch, fortran][4.4 Regression] Incorrect array value returned - 4.3 ABI Broken

[jvdelisle@verizon.net]

Janne Blomqvist wrote:
>
> Have you tried copying the 4.4 libgfortran over the 4.3 one and 
> running the 4.3 testsuite yet? I looked at ABI testing quite a while 
> ago and I came to the conclusion that while the above copying approach 
> is a bit kludgy it's the only one that works; IIRC the testsuite uses 
> some rpath trickery so you can't use use LD_LIBRARY_PATH to pick 
> another library.
>

Finally had a chance to try this.  I found the following failures:

fmt_zero_digits.f90: We changed the behavior and test case, expected.

The following failures were due to missing checks in inquire.c:

inquire.f90
inquire_5.f90
inquire_6.f90
inquire_7.f90
inquire_9.f90
negative_unit.f
pr20950.f
streamio_10.f90
streamio_3.f90
unf_io_convert_4.f90
execute/inquire_1.f90
execute/inquire_2.f90
execute/inquire_3.f90
execute/inquire_5.f90

The fix was obvious.  I committed the attached patch after regression 
testing with 4.4 and 4.3 compile running 4.4 library copied over.  The 
only difference from that approved by Janne is the simple checks in 
inquire.c.

No unexpected failures observed.

As best we can tell 4.3 ABI is no longer broken in 4.4.

Best Regards,

Jerry



-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr37498-f.diff
Type: application/octet-stream
Size: 26801 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20080926/2d1de28c/attachment.obj>