[patch, libgomp.fortran/testuite] fix uninstalled check problem on darwin8

IainS developer@sandoe-acoustics.co.uk
Wed Dec 10 12:45:00 GMT 2008


Hi,

With
http://gcc.gnu.org/ml/gcc/2008-12/msg00145.html

libgomp now has 126 more supported tests on darwin.
Also crayptr2 and pr32550 build without any special darwin target lines.

There are, as one might expect, some new failures.
I think that these relate to the emutls implementation (specifically  
32 bit code running on 64 bit processors).

Using '-lstatic-libgcc'/'-lgcc_eh' on darwin9 or '-lgcc_eh' on  
darwin8 seems to hide the problem somewhat.
However, I suspect that the sporadic failures of crayptr2 that  
Dominique has reported (and I have also seen) which occur even with - 
lstatic-libgcc.

therefore, I propose that the actual patch for this should be as  
below -- and, probably, should have been the patch to close PR32765

sorry for the high noise-level ... I'm still finding my way around!

( -fopenmp is attached to all cases by libgomp.exp - so it's not  
required unless there's some intention to test what happens with two  
copies).

these and the referenced patch have been bootstrap-lean and check-ed  
on powerpc-apple-darwin8.11.0 and i386-apple-darwin9.5.0
they are currently testing on powerpc-apple-darwin9.5.0 (32bit G4)  
and i386-apple-darwin9.5.0 (32bit intel)
I'll post all the results, once the two slower machines finish.

cheers,
Iain

Index: libgomp/testsuite/libgomp.fortran/crayptr2.f90
===================================================================
--- libgomp/testsuite/libgomp.fortran/crayptr2.f90      (revision  
142592)
+++ libgomp/testsuite/libgomp.fortran/crayptr2.f90      (working copy)
@@ -1,6 +1,6 @@
  ! { dg-do run }
-! { dg-options "-fopenmp -fcray-pointer" }
-! { dg-options "-fopenmp -fcray-pointer -static-libgcc" { target *-*- 
darwin* } }
+! { dg-options "-fcray-pointer" }
+! { dg-require-effective-target tls_runtime }

    use omp_lib
    integer :: a, b, c, d, p
Index: libgomp/testsuite/libgomp.fortran/pr32550.f90
===================================================================
--- libgomp/testsuite/libgomp.fortran/pr32550.f90       (revision  
142592)
+++ libgomp/testsuite/libgomp.fortran/pr32550.f90       (working copy)
@@ -1,6 +1,6 @@
  ! PR fortran/32550
  ! { dg-do run }
-! { dg-options "-static-libgcc" { target *-*-darwin* } }
+! { dg-require-effective-target tls_runtime }

        integer, pointer, save :: ptr
        integer, target :: targ



More information about the Fortran mailing list