ABSTRACT interfaces + PROCEDURE declarations
Tobias Schlüter
tobias.schlueter@physik.uni-muenchen.de
Fri Aug 17 19:00:00 GMT 2007
Tobias Burnus wrote:
> From my side Janus' patch (with my test case and Janus' bind(C) check
> replaced by mine) is OK.
>
> Janus: Can you write the ChangeLog, merge the patches* and send an email
> with your abstract interface patch to both fortran@ and to gcc-patches@?
> (* feel free to modify my test case or patch)
>
> I think it can then be checked in.
I take it that Tobias has reviewed the technical aspects, but I'd still
like to see testcases together with the patch. Also, there are still a
number of formatting issues. In gfc_match_procedure() the indenting is
consistently non-gnuish. There's also some #if 0'd code and a TODO that
makes me wonder if either that code should be merged with
match_attr_spec() or the common functionality be extracted from both.
The hunk to resolve_symbol() lacks vertical whitespace.
Cheers,
- Tobi
More information about the Fortran
mailing list