[patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)

Andreas Schwab schwab@suse.de
Sun Dec 10 19:58:00 GMT 2006


Tobias Burnus <burnus@net-b.de> writes:

> Hi Andreas, hi all,
>
>
> +#if HAVE_GETTIMEOFDAY  [...]
> +#if GETTIMEOFDAY_ONE_ARGUMENT
> +    if (!gettimeofday (&tp))
> +#else [...]
> +#if HAVE_STRUCT_TIMEZONE
> +    if (!gettimeofday (&tp, &tzp))
> +#else
> +    if (!gettimeofday (&tp, (void *) 0))
> +#endif /* HAVE_STRUCT_TIMEZONE  */
>
> Andreas Schwab wrote:
>> The timezone information is never used, why not always passing NULL for
>> it?  This is the only use of gettimeofday in libgfortran, it would also
>> make it possible to eliminate a runtime configure check.
>>   
> I don't know what you mean by runtime configure check.

AC_TRY_RUN.  Runtime checks are bad for cross compiling.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Fortran mailing list