[Fwd: [PATCH, libgfortran] Fix for PR24699, PR24700, PR24719]]

[Jerry DeLisle]

Paul Thomas wrote:
> :REVIEWMAIL:
> 
> Jerry,
> 
> I had to add your patch by hand because all 5 chunks failed.  I believe 
> that this is because of whitespace differences; your version has no tabs 
> and so the context was not recognized.  Please correct this.

Curious, there are tabs in my source and that is how I have set my editor. 
Maybe its my diff command.  I will check it.

> 
> Apart from this, the patch is fine.  It even does what it should do!  
> All three PRs are fixed.  I don't recall - did NIST check out OK with 
> the patch?  If you did not do it, please do not commit until every last 
> NIST test runs correctly.
> 
> pr24699.f90 is OK - it checks out the problem with aermod correctly.
> pr24719.f90 is OK, except for the print statement on line 12. Please 
> remove it.

I noticed that too, it is removed.

> 
> Why don't you take the original offering to Bugzilla as your testcase 
> for pr24785?  This works:
> 
> ! { dg-do run }
> ! ( dg-output "^" }
> !
> ! Test fix for pr24785 - EOR used to scrub the 2X.
> ! Reduced from PR example submitted by Harald Anlauf <anlauf@gmx.de>
> !
>      program x_with_advance_bug
>      write (*,'(A,2X)',  advance="no") "<"
>      write (*,'(A)') ">" ! { dg-output "<  >" }
>      end
>

This is great.  Now I have learned another "dg-" feature I can use.

Thanks,

Jerry