This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [Microblaze]: PIC Data Text Relative

From: Michael Eager <eager at eagerm dot com>
To: Andrew Sadek <andrew dot sadek dot se at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 20 Mar 2018 08:30:57 -0700
Subject: Re: [PATCH] [Microblaze]: PIC Data Text Relative
References: <CAE=jbAMyXXpWUPnC_dcmyWNeOXcJ-Wo4+KomQ9KwpX2KuLDqkg@mail.gmail.com> <CAE=jbAPxbV5TfeZKKubtWz3sE9221ofSFi9PwbN5X_=j+teCxQ@mail.gmail.com> <CAE=jbAOC7BG6=YDGkT8fvjBJ4JdMPBfgZVMLk9_qRgpzMDhSMA@mail.gmail.com> <9bd79491-266d-5b3e-217c-62dbb8ae1d74@eagerm.com> <CAE=jbAPs2yK=d4b_D31vVKjtvgpjjjs7g0N2CdVB75JW6Tjoqg@mail.gmail.com> <71c573a2-af37-9dfb-bbd1-b69bd2b56cbf@eagerm.com> <CAE=jbAOsht1g3EDCZeaqZ7A3JnVvziN-0AcZTOMTseq5sogW5Q@mail.gmail.com> <4515bb77-93e3-ead8-ab0b-7d23ca76adc3@eagerm.com> <CAE=jbAO6Y3eFtCV0VR0JMPEy5BeJCsKLebVG9DCRi=W_pdt3AA@mail.gmail.com> <076c5840-f9e2-320f-6f4c-658c986ef26d@eagerm.com> <CAE=jbAMCJ_8HR=ztOrY_FLfhYEMAFivyMO=Tz8EBdagd9zgs5g@mail.gmail.com> <CAE=jbAOOhvLe0_Tb_8i9y4P_X2OXkRrggqCQ=DOnUV=c0Kq2-g@mail.gmail.com> <bbc87995-edc7-ea58-24f0-a2d293dd3422@eagerm.com> <5cd4774f-13a2-5310-a27c-8298409be8d4@eagerm.com> <ac20eb8f-e97a-0234-8659-35e44b52965d@eagerm.com> <CAE=jbAO_1mhB7UHJyYeGrecGRjiDc_psoduQjy1tPcrC_L0v=Q@mail.gmail.com>

Hi Andrew --

I just do a visual check.  The script can help.

On 03/20/2018 07:13 AM, Andrew Sadek wrote:

Many Thanks Michael for the updates .. I was actually looking for something
similar for my test case .. I m currently revising the Gnu code conventions
on the patches then will send them again.
I m actually running the 'check_GNU_Style' in contrib folder,, is this the
correct way ? Is it enough ?

Andrew

On Tue, Mar 20, 2018, 03:30 Michael Eager <eager@eagerm.com> wrote:

Also check the { dg-skip-if } directive.
https://gcc.gnu.org/onlinedocs/gccint/Directives.html

On 03/19/2018 06:14 PM, Michael Eager wrote:

Hi Andrew --

Please take a look at the test case description:
https://gcc.gnu.org/wiki/HowToPrepareATestcase
and see if you can do one of the following:
    - Modify the regex expression in the scan-assembler to accept
      either format of generated output
or
    - Add { dg-option } directives to turn off your new options
      if specified.  (You should be able to specify -mno-pic....)
or
    - Duplicate the test cases and add { dg-option } directives
      to specify the correct options, with and without your
      new options.
or
    - Add test cases with a { dg-option } directive with your
      new options.

This is not required -- your patch appears to work OK.  Normally,
the new PIC Data options would not be used when running the test
suite, so the tests would not fail.  It's just nice to have the
test suite updated when new options are added.

On 03/19/2018 01:07 PM, Michael Eager wrote:

Hi Andrew --

Good work.

Please submit your updated patch.  Check that you follow
GNU coding standards.  Also make sure that the new options
are documented in gcc/doc/invoke.texi.

On 03/18/18 03:27, Andrew Sadek wrote:

Hello Michael,

I have run the test using the new PIC options.
Actually, I have discovered 2 unhandled cases in
'microblaze_expand_move' + missing conditions in linker relax
leading some test cases execution to fail.
After fixing them, I made a re-run for the whole regression, and the
results analogy below:

Original, without my patch:
          === gcc Summary ===

# of expected passes        90776
# of unexpected failures    1317
# of unexpected successes    3
# of expected failures        207
# of unresolved testcases    115
# of unsupported tests        2828

With my patch, calling '-fPIE - mpic-data-text-rel'
          === gcc Summary ===

# of expected passes        90843
# of unexpected failures    1256
# of unexpected successes    3
# of expected failures        207
# of unresolved testcases    115
# of unsupported tests        2853

After running the 'dg-cmp-results.sh' in contrib folder, the
PASS->FAIL are below:

PASS->FAIL: gcc.dg/uninit-19.c (test for excess errors)
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
-flto -fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
-flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
-flto -fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
-flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13

the 'gcc.dg/uninit-19.c ' already fails with -fPIE, and for the
others in microblaze,
expectation is r0 or r13 as a base register which is not the case
here 'r20', and these tests also fails with -fPIE.
Moreover, the test cases that failed due 'unresolved
GLOBAL_OFFSET_TABLE' now pass as we do not have GOT in data text
relative.

Please tell me if any adjustments needed or If I need to re-run

nything.


Thanks

On Sun, Mar 18, 2018 at 12:25 PM, Andrew Sadek
<andrew.sadek.se@gmail.com <mailto:andrew.sadek.se@gmail.com>> wrote:

     Hello Michael,

     I have run the test using the new PIC options.
     Actually, I have discovered 2 unhandled cases in
     'microblaze_expand_move' + missing conditions in linker relax
     leading some test cases execution to fail.
     After fixing them, I made a re-run for the whole regression, and

the

     results analogy below:

     Original, without my patch:
              === gcc Summary ===

     # of expected passes        90776
     # of unexpected failures    1317
     # of unexpected successes    3
     # of expected failures        207
     # of unresolved testcases    115
     # of unsupported tests        2828

     With my patch, calling '-fPIE - mpic-data-text-rel'
              === gcc Summary ===

     # of expected passes        90843
     # of unexpected failures    1256
     # of unexpected successes    3
     # of expected failures        207
     # of unresolved testcases    115
     # of unsupported tests        2853

     After running the 'dg-cmp-results.sh' in contrib folder, the
     PASS->FAIL are below:

     PASS->FAIL: gcc.dg/uninit-19.c (test for excess errors)
     PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
     -fno-use-linker-plugin -flto-partition=none   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
     -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
     -fno-use-linker-plugin -flto-partition=none   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
     -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
     PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
     -fno-use-linker-plugin -flto-partition=none   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
     -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
     -fno-use-linker-plugin -flto-partition=none   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
     -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
     -fno-use-linker-plugin -flto-partition=none   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
     -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
     -fno-use-linker-plugin -flto-partition=none   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
     -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c
-O0     scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c
-O1     scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
     -flto -fno-use-linker-plugin -flto-partition=none   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
     -flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c
-O2     scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O3
     -g   scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c
-Os     scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c
-O0     scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c
-O1     scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
     -flto -fno-use-linker-plugin -flto-partition=none   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
     -flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
     lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c
-O2     scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O3
     -g   scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
     PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c
-Os     scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13

     the 'gcc.dg/uninit-19.c ' already fails with -fPIE, and for the
     others in microblaze,
     expectation is r0 or r13 as a base register which is not the case
     here 'r20', and these tests also fails with -fPIE.
     Moreover, the test cases that failed due 'unresolved
     GLOBAL_OFFSET_TABLE' now pass as we do not have GOT in data text
     relative.

     Attached the compare output of the scripit with verbosity 2.
     Please tell me if any adjustments needed or If I need to re-run
nything.

     Thanks


     On Tue, Mar 13, 2018 at 10:44 PM, Michael Eager <eager@eagerm.com
     <mailto:eager@eagerm.com>> wrote:

         On 03/13/18 00:56, Andrew Sadek wrote:

             Ok, so you mean with '-fPIC -mpic-data-text-relative' as I
             do in my test case ?
             If all is Ok, execution and compilation shall ideally pass
             for the test cases.


         Correct.

         I want to make sure of two things:
            -- Your patch doesn't break anything (i.e., cause a
         regression) when
               you don't use the options.  This seems complete.
            -- Your patch works as intended when you do use the options.

             But I have noticed that there are some output pattern

checks

             done in some test cases and this may fail since the output
             assembly is different,
             anyway I shall give it a try and send you the results with
             the new options.


         There should be no target dependencies in the generic GCC

tests.

         Different instruction patterns which generate the correct
         results should
         not be a problem.


         --         Michael Eager eager@eagerm.com
<mailto:eager@eagerm.com>
         1960 Park Blvd., Palo Alto, CA 94306




     --
     Andrew




--

Andrew


--
Michael Eager    eager@eagerm.com
1960 Park Blvd., Palo Alto, CA 94306


--
Michael Eager    eager@eagerm.com
1960 Park Blvd., Palo Alto, CA 94306

Follow-Ups:
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek

References:
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]