This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [Microblaze]: PIC Data Text Relative

From: Andrew Sadek <andrew dot sadek dot se at gmail dot com>
To: Michael Eager <eager at eagerm dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sun, 18 Mar 2018 12:27:47 +0200
Subject: Re: [PATCH] [Microblaze]: PIC Data Text Relative
References: <CAE=jbAMyXXpWUPnC_dcmyWNeOXcJ-Wo4+KomQ9KwpX2KuLDqkg@mail.gmail.com> <3ea62194-f081-0d2e-13f4-5884f1615e37@eagerm.com> <CAE=jbAPxbV5TfeZKKubtWz3sE9221ofSFi9PwbN5X_=j+teCxQ@mail.gmail.com> <CAE=jbAOC7BG6=YDGkT8fvjBJ4JdMPBfgZVMLk9_qRgpzMDhSMA@mail.gmail.com> <9bd79491-266d-5b3e-217c-62dbb8ae1d74@eagerm.com> <CAE=jbAPs2yK=d4b_D31vVKjtvgpjjjs7g0N2CdVB75JW6Tjoqg@mail.gmail.com> <71c573a2-af37-9dfb-bbd1-b69bd2b56cbf@eagerm.com> <CAE=jbAOsht1g3EDCZeaqZ7A3JnVvziN-0AcZTOMTseq5sogW5Q@mail.gmail.com> <4515bb77-93e3-ead8-ab0b-7d23ca76adc3@eagerm.com> <CAE=jbAO6Y3eFtCV0VR0JMPEy5BeJCsKLebVG9DCRi=W_pdt3AA@mail.gmail.com> <076c5840-f9e2-320f-6f4c-658c986ef26d@eagerm.com> <CAE=jbAMCJ_8HR=ztOrY_FLfhYEMAFivyMO=Tz8EBdagd9zgs5g@mail.gmail.com>

Hello Michael,

I have run the test using the new PIC options.
Actually, I have discovered 2 unhandled cases in 'microblaze_expand_move' +
missing conditions in linker relax
leading some test cases execution to fail.
After fixing them, I made a re-run for the whole regression, and the
results analogy below:

Original, without my patch:
        === gcc Summary ===

# of expected passes        90776
# of unexpected failures    1317
# of unexpected successes    3
# of expected failures        207
# of unresolved testcases    115
# of unsupported tests        2828

With my patch, calling '-fPIE - mpic-data-text-rel'
        === gcc Summary ===

# of expected passes        90843
# of unexpected failures    1256
# of unexpected successes    3
# of expected failures        207
# of unresolved testcases    115
# of unsupported tests        2853

After running the 'dg-cmp-results.sh' in contrib folder, the PASS->FAIL are
below:

PASS->FAIL: gcc.dg/uninit-19.c (test for excess errors)
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O0   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O1   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -Os   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O0   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O1   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -Os   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O0
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O1
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2 -flto
-fno-use-linker-plugin -flto-partition=none   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2 -flto
-fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O3 -g
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -Os
scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13

the 'gcc.dg/uninit-19.c ' already fails with -fPIE, and for the others in
microblaze,
expectation is r0 or r13 as a base register which is not the case here
'r20', and these tests also fails with -fPIE.
Moreover, the test cases that failed due 'unresolved GLOBAL_OFFSET_TABLE'
now pass as we do not have GOT in data text relative.

Please tell me if any adjustments needed or If I need to re-run nything.

Thanks

On Sun, Mar 18, 2018 at 12:25 PM, Andrew Sadek <andrew.sadek.se@gmail.com>
wrote:

> Hello Michael,
>
> I have run the test using the new PIC options.
> Actually, I have discovered 2 unhandled cases in 'microblaze_expand_move'
> + missing conditions in linker relax
> leading some test cases execution to fail.
> After fixing them, I made a re-run for the whole regression, and the
> results analogy below:
>
> Original, without my patch:
>         === gcc Summary ===
>
> # of expected passes        90776
> # of unexpected failures    1317
> # of unexpected successes    3
> # of expected failures        207
> # of unresolved testcases    115
> # of unsupported tests        2828
>
> With my patch, calling '-fPIE - mpic-data-text-rel'
>         === gcc Summary ===
>
> # of expected passes        90843
> # of unexpected failures    1256
> # of unexpected successes    3
> # of expected failures        207
> # of unresolved testcases    115
> # of unsupported tests        2853
>
> After running the 'dg-cmp-results.sh' in contrib folder, the PASS->FAIL
> are below:
>
> PASS->FAIL: gcc.dg/uninit-19.c (test for excess errors)
> PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O0
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O1
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
> -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O3 -g
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -Os
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O0
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O1
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
> -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O3 -g
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -Os
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O0
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O1
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
> -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O3 -g
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -Os
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O0
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O1
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
> -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O3 -g
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -Os
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O0
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O1
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
> -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O3 -g
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -Os
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O0
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O1
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
> -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O3 -g
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -Os
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O0
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O1
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2 -flto
> -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O3 -g
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -Os
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O0
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O1
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2 -flto
> -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O3 -g
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -Os
> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>
> the 'gcc.dg/uninit-19.c ' already fails with -fPIE, and for the others in
> microblaze,
> expectation is r0 or r13 as a base register which is not the case here
> 'r20', and these tests also fails with -fPIE.
> Moreover, the test cases that failed due 'unresolved GLOBAL_OFFSET_TABLE'
> now pass as we do not have GOT in data text relative.
>
> Attached the compare output of the scripit with verbosity 2.
> Please tell me if any adjustments needed or If I need to re-run nything.
>
> Thanks
>
>
> On Tue, Mar 13, 2018 at 10:44 PM, Michael Eager <eager@eagerm.com> wrote:
>
>> On 03/13/18 00:56, Andrew Sadek wrote:
>>
>>> Ok, so you mean with '-fPIC -mpic-data-text-relative' as I do in my test
>>> case ?
>>> If all is Ok, execution and compilation shall ideally pass for the test
>>> cases.
>>>
>>
>> Correct.
>>
>> I want to make sure of two things:
>>   -- Your patch doesn't break anything (i.e., cause a regression) when
>>      you don't use the options.  This seems complete.
>>   -- Your patch works as intended when you do use the options.
>>
>> But I have noticed that there are some output pattern checks done in some
>>> test cases and this may fail since the output assembly is different,
>>> anyway I shall give it a try and send you the results with the new
>>> options.
>>>
>>
>> There should be no target dependencies in the generic GCC tests.
>> Different instruction patterns which generate the correct results should
>> not be a problem.
>>
>>
>> --
>> Michael Eager    eager@eagerm.com
>> 1960 Park Blvd., Palo Alto, CA 94306
>>
>
>
>
> --
>
> Andrew
>



-- 

Andrew

Follow-Ups:
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager

References:
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Andrew Sadek
- Re: [PATCH] [Microblaze]: PIC Data Text Relative
  - From: Michael Eager

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]