This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c
- From: Mike Stump <mikestump at comcast dot net>
- To: Jeff Law <law at redhat dot com>
- Cc: James Greenhalgh <james dot greenhalgh at arm dot com>, Senthil Kumar Selvaraj <senthil_kumar dot selvaraj at atmel dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, nd at arm dot com
- Date: Tue, 27 Sep 2016 14:41:47 -0700
- Subject: Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c
- Authentication-results: sourceware.org; auth=none
- References: <87oa398uox.fsf@atmel.com> <20160927163944.GA31038@arm.com> <00cd3217-d35f-fc69-de3f-36e0b11a6d34@redhat.com>
On Sep 27, 2016, at 11:38 AM, Jeff Law <law@redhat.com> wrote:
>
> On 09/27/2016 10:39 AM, James Greenhalgh wrote:
>> On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote:
>>> Hi,
>>>
>>> This patch requires int32plus for
>>> gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, as it reports a bunch of
>>> failures for a 16 bit int target like the avr. The "%u" format
>>> specifier tests, for example, use int literals big enough to only fit
>>> in a long int, and this causes unexpected warnings.
>>>
>>> Comitted to trunk.
>>
>> This change is obviously incomplete as it does not update the expected
>> line numbers for warnings generated by this testcase.
> Right.
>
> It does make me wonder if these directives could go at the bottom of the file so that adding/removing a directive doesn't require updating line #s in the file.
We support relative numbers in some of the places now, right? :-) absolute line numbers should be recoded to relative numbers as people hit them.