This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c


On 09/27/2016 03:41 PM, Mike Stump wrote:
On Sep 27, 2016, at 11:38 AM, Jeff Law <law@redhat.com> wrote:

On 09/27/2016 10:39 AM, James Greenhalgh wrote:
On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote:
Hi,

 This patch requires int32plus for
 gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, as it reports a bunch of
 failures for a 16 bit int target like the avr. The "%u" format
 specifier tests, for example, use int literals big enough to only fit
 in a long int, and this causes unexpected warnings.

 Comitted to trunk.

This change is obviously incomplete as it does not update the expected
line numbers for warnings generated by this testcase.
Right.

It does make me wonder if these directives could go at the bottom of the file so that adding/removing a directive doesn't require updating line #s in the file.

We support relative numbers in some of the places now, right?  :-)  absolute line numbers should be recoded to relative numbers as people hit them.

Yea, that's probably an even better solution.
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]