This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: divmod transform: add test-cases
- From: Jeff Law <law at redhat dot com>
- To: Prathamesh Kulkarni <prathamesh dot kulkarni at linaro dot org>, Richard Biener <rguenther at suse dot de>, Kugan Vivekanandarajah <kugan dot vivekanandarajah at linaro dot org>, Jim Wilson <jim dot wilson at linaro dot org>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, gcc Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 11 Aug 2016 16:02:54 -0600
- Subject: Re: divmod transform: add test-cases
- Authentication-results: sourceware.org; auth=none
- References: <CAAgBjMnFt_8ZQzb_hW3ktTAnjAxrJ=XD_3E44=WoTFamOTaoXQ@mail.gmail.com> <CAAgBjMmgTh6O=CDgvyL4bFktkx3ND751SLje4-2HHfW9BeegzQ@mail.gmail.com>
On 08/09/2016 04:58 AM, Prathamesh Kulkarni wrote:
ping https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01869.html
This seems to be dependent upon other patches, this is not OK until all
prereqs are resolved.
You're using SI/DI in the descriptions, but then using more traditional
C types like int, unsigned, long long in the actual test.
If you intent is really to nail down SI/DI mode testing, then the way to
go will be to define typedefs that correspond directly to SI and DI modes:
typedef unsigned int u32 __attribute__((mode(SI)));
typedef signed int s32 __attribute__((mode(SI)));
You can do something similar for DImode.
It may not matter because of your effective-target
{divmod,divmod_simode} selectors, but it still seems cleaner.
With that change, this is OK when its prereqs are resolved.
jeff