Re: [patch] Add baseline for SPARC64/Linux

[Jonathan Wakely <jwakely at redhat dot com>]

On 22/02/19 21:26 +0100, Jakub Jelinek wrote:
> On Fri, Feb 22, 2019 at 08:24:09PM +0000, Jonathan Wakely wrote:
> > > > We don't usually include the __once_callable symbols in the baseline
> > > > file, are you sure it's correct to do so for sparc64-linux-gnu?
> > > >
> > > > +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
> > > > +TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > >
> > > It shouldn't be there on any target, as it will differ between configuring
> > > the library with and without TLS.
> >
> > Right, that's my understanding. We get that wrong though:
>
> Maybe it would be best to include them but if the compiler is configured
> without native TLS ignore the TLS lines.

That should be a pretty easy change to the tests, I'll add it to my
TODO list.

> > config/abi/post/x86_64-linux-gnu/x32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/i386-solaris2.11/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/i386-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/mips64-linux-gnu/64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/mips64-linux-gnu/32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/i386-solaris2.10/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/i386-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/sparc-solaris2.10/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/sparc-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/sparc-solaris2.11/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> > config/abi/post/sparc-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
>
> 	Jakub