This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Add baseline for SPARC64/Linux

From: Jonathan Wakely <jwakely at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Eric Botcazou <ebotcazou at adacore dot com>, libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Fri, 22 Feb 2019 20:24:09 +0000
Subject: Re: [patch] Add baseline for SPARC64/Linux
References: <5024844.KlZsQ8QBrG@polaris> <4062895.AP2ia1RWNV@polaris> <20190222192457.GM13569@redhat.com> <20190222194303.GG7611@tucnak>

On 22/02/19 20:43 +0100, Jakub Jelinek wrote:

On Fri, Feb 22, 2019 at 07:24:57PM +0000, Jonathan Wakely wrote:

On 22/02/19 08:27 +0100, Eric Botcazou wrote:
> > 2019-02-20  Eric Botcazou  <ebotcazou@adacore.com>
> >
> >         * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux.
> >         * config/abi/post/sparc64-linux-gnu: New directory.
> >         * config/abi/post/sparc64-linux-gnu/baseline_symbols.txt: New file.
> >         * config/abi/post/sparc64-linux-gnu/32: New directory.
> >       * config/abi/post/sparc64-linux-gnu/32/baseline_symbols.txt: New file.
>
> I can probably self-approve it as SPARC maintainer so now installed.

Sorry for the delay, I'm in a meeting all week with limited time for
patch review.

We don't usually include the __once_callable symbols in the baseline
file, are you sure it's correct to do so for sparc64-linux-gnu?

+TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
+TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11


It shouldn't be there on any target, as it will differ between configuring
the library with and without TLS.


Right, that's my understanding. We get that wrong though:

config/abi/post/x86_64-linux-gnu/x32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/i386-solaris2.11/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/i386-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/mips64-linux-gnu/64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/mips64-linux-gnu/32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/i386-solaris2.10/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/i386-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/sparc-solaris2.10/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/sparc-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/sparc-solaris2.11/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/sparc-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11

Follow-Ups:
- Re: [patch] Add baseline for SPARC64/Linux
  - From: Jakub Jelinek

References:
- [patch] Add baseline for SPARC64/Linux
  - From: Eric Botcazou
- Re: [patch] Add baseline for SPARC64/Linux
  - From: Eric Botcazou
- Re: [patch] Add baseline for SPARC64/Linux
  - From: Jonathan Wakely
- Re: [patch] Add baseline for SPARC64/Linux
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]