This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR libstdc++/86734 make reverse_iterator::operator-> more robust

From: Jonathan Wakely <jwakely at redhat dot com>
To: François Dumont <frs dot dumont at gmail dot com>
Cc: libstdc++ at gcc dot gnu dot org
Date: Tue, 31 Jul 2018 20:26:46 +0100
Subject: Re: [PATCH] PR libstdc++/86734 make reverse_iterator::operator-> more robust
References: <20180730172609.GA23718@redhat.com> <999c7e90-2136-9816-d3a1-552876c05b37@gmail.com>

On 31/07/18 20:36 +0200, François Dumont wrote:

As you are talking about std::reverse_iterator I noticed this instl_iterator.h:
#if __cplusplus >= 201103L
  // Same as C++14 make_reverse_iterator but used in C++03 mode too.
IMO the comment should be fixed but maybe you prefer the macro checkto be removed ?


I agree that just fixing the comment is best.

If you agree that it is the comment I can do it as a trivial fix.


Please go ahead - thanks!

References:
- [PATCH] PR libstdc++/86734 make reverse_iterator::operator-> more robust
  - From: Jonathan Wakely
- Re: [PATCH] PR libstdc++/86734 make reverse_iterator::operator-> more robust
  - From: François Dumont

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]