Re: [PATCH] PR libstdc++/86734 make reverse_iterator::operator-> more robust

[François Dumont <frs dot dumont at gmail dot com>]

As you are talking about std::reverse_iterator I noticed this in 
stl_iterator.h:

#if __cplusplus >= 201103L
  // Same as C++14 make_reverse_iterator but used in C++03 mode too.

IMO the comment should be fixed but maybe you prefer the macro check to 
be removed ?

If you agree that it is the comment I can do it as a trivial fix.

François

On 30/07/2018 19:26, Jonathan Wakely wrote:
> Implement the proposed resolution from LWG 1052, which also resolves
> DR 2118 by avoiding taking the address in the first place.
>
>     PR libstdc++/86734
>     * include/bits/stl_iterator.h (reverse_iterator::operator->): Call
>     _S_to_pointer (LWG 1052, LWG 2118).
>     (reverse_iterator::_S_to_pointer): Define overloaded helper 
> functions.
>     * testsuite/24_iterators/reverse_iterator/dr1052.cc: New test.
>     * testsuite/24_iterators/reverse_iterator/dr2188.cc: New test.
>
> Tested powerpc64le-linux, committed to trunk.