This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Remove algo logic duplication Round 3
- From: Marc Glisse <marc dot glisse at inria dot fr>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: libstdc++ at gcc dot gnu dot org, François Dumont <frs dot dumont at gmail dot com>
- Date: Sun, 29 Sep 2013 20:50:26 +0300 (EEST)
- Subject: Re: Remove algo logic duplication Round 3
- Authentication-results: sourceware.org; auth=none
- References: <52409F6F dot 7040609 at gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1309232317070 dot 4088 at laptop-mg dot saclay dot inria dot fr> <alpine dot DEB dot 2 dot 10 dot 1309290031480 dot 4104 at laptop-mg dot saclay dot inria dot fr> <6db06268-bf11-49d8-8431-6687c2967a85 at email dot android dot com>
- Reply-to: libstdc++ at gcc dot gnu dot org
On Sun, 29 Sep 2013, Paolo Carlini wrote:
Maybe we could use more references? The user-facing functions have to
take iterators by value, but I think the inline helpers could use
references.
Marc it would be great if you could prepare a patch or provide (offline
too, if you like) detailed guidance to Francois. We really want this
change to be safe and nop (or very close to that) from the performance
point of view. That's why I remained unconvinced and hesitant for such a
long time. If we are not sure, let's just admit it, give the issue more
thought and reconsider a more satisfactory patch for the next release
series.
Busy now, but please don't revert the patch because of my post. The number
of copies in the previous code was already rather large, showing that we
didn't care about it. The new code increases it a bit, but only by a
constant factor. We can improve that incrementally, I believe.
--
Marc Glisse