This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Remove algo logic duplication Round 3
- From: Marc Glisse <marc dot glisse at inria dot fr>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 23 Sep 2013 23:35:10 +0200 (CEST)
- Subject: Re: Remove algo logic duplication Round 3
- Authentication-results: sourceware.org; auth=none
- References: <52409F6F dot 7040609 at gmail dot com>
- Reply-to: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
On Mon, 23 Sep 2013, François Dumont wrote:
Here is a new version of the patch.
And I was almost getting used to the idea we would use less<void> ;-)
I didn't read it in details, but I'll ask a question anyway, because I am
a pain that way: did you check how much more we are copying iterators and
predicates in this new code compared to the old one? I know those
operations aren't supposed to be super expensive, but still...
I was wondering if we should mark the predefined ops as inline to help the
compiler early-inline them and make it more likely it will generate the
same code as before, or if that may prevent the compiler from doing even
better choices. Probably not worth the trouble.
--
Marc Glisse