This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] regex_iterator and regex_token_iterator implementation
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 22 Jul 2013 08:12:46 +0200
- Subject: Re: [Patch] regex_iterator and regex_token_iterator implementation
- References: <CAPrifDm07qvEoJEC9BBkRa1yuCrM9vXRoDPTXfJEjfVmj=XKNQ at mail dot gmail dot com> <51EC86EE dot 20004 at oracle dot com> <CAPrifDk8Ur4m3P+Jr-sb231LvWzBPoWFA83hNMRsM5zgP9J0eA at mail dot gmail dot com> <3a2ffb73-f678-4b72-8900-b793b5d18115 at email dot android dot com> <CAPrifDkDvi4WnVAwyVJAkjz29-DUqzZCEKSRruCbyhkrbgQEYg at mail dot gmail dot com>
Hi,
>Great. This is the fixed version.
Patch is Ok with me but before committing please give a chance to Jon and other interested parties to have a look.
Two more general comments: when you opencode more than a few lines don't hesitate to add comments too (remember that the new code must be maintained over the years and not necessarily by yourself ;) Also, at some point you should add appropriate .tcc headers for the out of line functions.
Paolo