This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] regex_iterator and regex_token_iterator implementation
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 22 Jul 2013 03:12:14 +0200
- Subject: Re: [Patch] regex_iterator and regex_token_iterator implementation
- References: <CAPrifDm07qvEoJEC9BBkRa1yuCrM9vXRoDPTXfJEjfVmj=XKNQ at mail dot gmail dot com>
On 07/22/2013 02:47 AM, Tim Shen wrote:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57513 is already in the
testsuite and can passed(even before this patch?).
To fully test it, a fully regex_search implementation is required. I'm
working on a (damning) backtracking engine for it.
A couple of comments on the patch: the operator++, operator=,
operator==, and _M_init are definitely too big to be inline. Also you
are wrongly "un-uglyfying" many names, eg:
- position_iterator __position;
- const value_type* __result;
- value_type __suffix;
- std::size_t __n;
- std::vector<int> __subs;
Remember all the names must begin by double underscore or single
underscore, etc.
Paolo.